How code contributions are reviewed

 

It is DMC policy that all submitted both by internal and external contributors is tested and reviewed as part of our Quality Assurance Process

 

For Internal Contributors – people explicitly hired to work on the DMC

  1. Code is created in local branch and tested by creator
  2. A pull request is submitted to the maintainer of the specific master branch
  3. Before code is merged into the master branch automated tests must be run and test code coverage of 80% must be achieved
  4. Code is inspected by the maintainer of the master branch
  5. Code is merged into master repository

For External Contributors – people from our broader community that seek to participate

  1. Code is created in local branch and tested by creator
  2. A pull request is submitted to the maintainer of the specific master branch
  3. Before code is merged into the master branch automated tests must be run and test code coverage of 100% must be achieved
  4. Code is inspected by the maintainer of the master branch and a second peer and consensus must be reached the code is safe
  5. Code is merged into master repository